linux-kernel - sound: bebop: strncmp length oddity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477777020.23018.8.camel@perches.com>
Date:   Sat, 29 Oct 2016 14:37:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Takashi Sakamoto <o-takashi@...amocchi.jp>
Cc:     Takashi Iwai <tiwai@...e.com>,
        Clemens Ladisch <clemens@...isch.de>,
        alsa-devel <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: sound: bebop: strncmp length oddity

15 isn't the length of the string, is that really what's desired?

linux/next/sound/firewire/bebob/bebop.c

-----------------------------

static bool
check_audiophile_booted(struct fw_unit *unit)
{
	char name[24] = {0};

	if (fw_csr_string(unit->directory, CSR_MODEL, name, sizeof(name)) < 0)
		return false;

	return strncmp(name, "FW Audiophile Bootloader", 15) != 0;
}