linux-kernel - RFC if==else in i40iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 30 Oct 2016 12:33:25 +0000
From:   Nicholas Mc Guire <der.herr@...r.at>
To:     Faisal Latif <faisal.latif@...el.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RFC if==else in i40iw_virtchnl.

Hi Faisal !

 your commit 4097351a47c5 ("i40iw: virtual channel handling files")
 adds the following lines in i40iw_vchnl_recv_pf()

+               if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0)
+                       vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
+               else
+                       vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
+               return I40IW_SUCCESS;

 as the if==else here this looks buggy - if it is intended it atleast needs
 a comment/explaination but it did not seem to make much sense in this
 form (Note this is the only place where vchnl_pf_send_get_ver_resp() is 
 being called so the intent is not clear from code review and thus no patch 
 can be resonably suggested.

thx!
hofrat