linux-kernel - Re: [PATCH 3/3] s390: char: make slp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161030144308.03a804de@mschwide>
Date:   Sun, 30 Oct 2016 14:43:08 +0100
From:   Martin Schwidefsky <schwidefsky@...ibm.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
        <linux-s390@...r.kernel.org>
Subject: Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular

On Sat, 29 Oct 2016 16:38:43 -0400
Paul Gortmaker <paul.gortmaker@...driver.com> wrote:

> The Makefile currently controlling compilation of this code is obj-y,
> meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular usage, so that when reading
> the driver there is no doubt it is builtin-only.
> 
> Since module_misc_device translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Michael Holzheu <holzheu@...ux.vnet.ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

That idea behind the patch makes sense to me. But the built robot
reports a new warning which should be fixed. If that is done:

Acked-by: Martin Schwidefsky <schwidefsky@...ibm.com>

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.