linux-kernel - Re: [PATCH] idle/i7300: Add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161030163247.l5nj4b52un3nef6z@pd.tnic>
Date:   Sun, 30 Oct 2016 17:32:47 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Henroid <andrew.d.henroid@...el.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] idle/i7300: Add CONFIG_PCI dependency

On Sun, Oct 30, 2016 at 07:54:44AM -0700, Randy Dunlap wrote:
> 	depends on PCI
> (no CONFIG_ prefix)

Whoops!

Thanks. FWIW, it didn't fire even with "depends on CONFIG_PCI" anymore.
Didn't investigate why though...

---
From: Borislav Petkov <bp@...e.de>
Date: Sun, 30 Oct 2016 14:39:28 +0100
Subject: [PATCH] idle/i7300: Add CONFIG_PCI dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

... in order to fix this randconfig build warning:

  drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’:
  ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized]
    int __ret_warn_once = !!(condition);   \
                          ^
  drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here
    u8 got_ctl;
       ^

Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: Andy Henroid <andrew.d.henroid@...el.com>
Cc: linux-pm@...r.kernel.org
---
 drivers/idle/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig
index 4732dfc15447..a066fca3688f 100644
--- a/drivers/idle/Kconfig
+++ b/drivers/idle/Kconfig
@@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL
 config I7300_IDLE
 	tristate "Intel chipset idle memory power saving driver"
 	select I7300_IDLE_IOAT_CHANNEL
+	depends on PCI
 	help
 	  Enable memory power savings when idle with certain Intel server
 	  chipsets. The chipset must have I/O AT support, such as the
-- 
2.10.0

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.