linux-kernel - Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a632b81f-c33d-e506-c9e6-762a5c7f6c3f@m4x.org>
Date:   Sun, 30 Oct 2016 17:57:10 +0100
From:   Nicolas Iooss <nicolas.iooss_linux@....org>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

On 30/10/16 16:50, Dan Williams wrote:
> On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
> <nicolas.iooss_linux@....org> wrote:
>> In order to test that the name of a resource begins with "pmem", call
>> strncmp() with 4 as length instead of 3 to match the whole prefix.
>>
>> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
>> for multi-pmem")
>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
> 
> Thanks, although I would not call this out as a fix since the length
> parameter could be 1 and still do the right thing.  I.e. we're
> distinguishing "blk" from "pmem" resources.  I'll add this for 4.10 as
> a cleanup.

All right. Thanks for your quick reply!

Nicolas