linux-kernel - Re: [PATCH] dmaengine: nbpfaxi: add optional max-burst property for memory reads/writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161030204147.ysm6vsubfclae57y@rob-hp-laptop>
Date:   Sun, 30 Oct 2016 15:41:48 -0500
From:   Rob Herring <robh@...nel.org>
To:     Niklas Cassel <niklas.cassel@...s.com>
Cc:     vinod.koul@...el.com, mark.rutland@....com,
        dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Niklas Cassel <niklass@...s.com>
Subject: Re: [PATCH] dmaengine: nbpfaxi: add optional max-burst property for
 memory reads/writes

On Mon, Oct 24, 2016 at 03:29:15PM +0200, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@...s.com>
> 
> Due to a hardware bug, reading memory (from the Accelerator Coherency Port)
> with a burst size equal to the maximum burst size allowed by the DMA
> hardware's buffer size will cause a hardware hang on the ARTPEC-6 SoC,
> where the only solution is a manual power cycle.
> On ARTPEC-6, this hardware bug does not trigger when writing memory (to the
> Accelerator Coherency Port) with a burst size equal to the maximum burst
> size allowed by the DMA hardware's buffer size.
> 
> To avoid this hardware hang, introduce a new optional max-burst property
> for memory reads. For completeness, also introduce a max-burst property for
> memory writes.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>
> ---
>  Documentation/devicetree/bindings/dma/nbpfaxi.txt |  8 +++++
>  drivers/dma/nbpfaxi.c                             | 38 ++++++++++++++++++++---
>  2 files changed, 42 insertions(+), 4 deletions(-)

Acked-by: Rob Herring <robh@...nel.org>