linux-kernel - Re: [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15d36902-418e-74d8-0405-1efa21a265bb@nvidia.com>
Date:   Mon, 31 Oct 2016 11:29:01 +0530
From:   Kirti Wankhede <kwankhede@...dia.com>
To:     Jike Song <jike.song@...el.com>
CC:     <alex.williamson@...hat.com>, <pbonzini@...hat.com>,
        <kraxel@...hat.com>, <cjia@...dia.com>, <qemu-devel@...gnu.org>,
        <kvm@...r.kernel.org>, <kevin.tian@...el.com>,
        <bjsdjshi@...ux.vnet.ibm.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify
 DMA_UNMAP



On 10/31/2016 9:20 AM, Jike Song wrote:
> On 10/27/2016 05:29 AM, Kirti Wankhede wrote:
>> Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers
>> about DMA_UNMAP.
>> Exported two APIs vfio_register_notifier() and vfio_unregister_notifier().
>> Vendor driver should register notifer using these APIs.
>> Vendor driver should use VFIO_IOMMU_NOTIFY_DMA_UNMAP action to invalidate
>> mappings.
>>
>> Signed-off-by: Kirti Wankhede <kwankhede@...dia.com>
>> Signed-off-by: Neo Jia <cjia@...dia.com>
>> Change-Id: I5910d0024d6be87f3e8d3e0ca0eaeaaa0b17f271
>> ---
>>  drivers/vfio/vfio.c             | 73 +++++++++++++++++++++++++++++++++
>>  drivers/vfio/vfio_iommu_type1.c | 89 ++++++++++++++++++++++++++++++++++++-----
>>  include/linux/vfio.h            | 11 +++++
>>  3 files changed, 163 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
>> index 28b50ca14c52..ff05ac6b1e90 100644
>> --- a/drivers/vfio/vfio.c
>> +++ b/drivers/vfio/vfio.c
>> @@ -1891,6 +1891,79 @@ err_unpin_pages:
>>  }
>>  EXPORT_SYMBOL(vfio_unpin_pages);
>>  
>> +int vfio_register_notifier(struct device *dev, struct notifier_block *nb)
>> +{
> 
> Hi Kirti,
> 
> Given that below 4 methods are members of vfio_iommu_driver_ops:
> 
> 	pin_pages
> 	unpin_pages
> 	register_notifier
> 	unregister_notifier
> 
> the names of exposed VFIO APIs could possibly be clearer:
> 
> 	vfio_iommu_pin_pages
> 	vfio_iommu_unpin_pages
> 	vfio_iommu_register_notifier
> 	vfio_iommu_unreigster_nodier
> 

Hey Jike,

I had followed the same style as other members in this structure:

	attach_group
	detach_group

Thanks,
Kirti