linux-kernel - Re: [PATCH 08/15] powerpc/iommu: use permission-specific DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87twbt127x.fsf@concordia.ellerman.id.au>
Date:   Mon, 31 Oct 2016 17:06:58 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     kernel-janitors@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/15] powerpc/iommu: use permission-specific DEVICE_ATTR variants

Julia Lawall <Julia.Lawall@...6.fr> writes:

> diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
> index 5f202a5..32f18b5 100644
> --- a/arch/powerpc/kernel/iommu.c
> +++ b/arch/powerpc/kernel/iommu.c
> @@ -127,8 +127,7 @@ static ssize_t fail_iommu_store(struct device *dev,
>  	return count;
>  }
>  
> -static DEVICE_ATTR(fail_iommu, S_IRUGO|S_IWUSR, fail_iommu_show,
> -		   fail_iommu_store);
> +static DEVICE_ATTR_RW(fail_iommu);

Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)


cheers