linux-kernel - Re: [PATCH] cxl: Fix memory allocation failure test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <99cf0e87-a130-446b-0628-9fba55098dda@au1.ibm.com>
Date:   Mon, 31 Oct 2016 17:16:46 +1100
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        imunsie@....ibm.com, fbarrat@...ux.vnet.ibm.com
Cc:     kernel-janitors@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl: Fix memory allocation failure test

On 31/10/16 06:35, Christophe JAILLET wrote:
> 'cxl_context_alloc()' does not return an error pointer. It is just a
> shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the
> size parameter.
>
> So its return value should be compared with NULL.
> While fixing it, simplify a bit the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Andrew Donnellan <andrew.donnellan@....ibm.com>

> ---
> un-compiled because I don't have the required  cross build environment.

Compiles on my system!

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited