linux-kernel - Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161031080534.GB2207@Socrates-DK>
Date:   Mon, 31 Oct 2016 16:05:35 +0800
From:   Eva Rachel Retuya <eraretuya@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Michael.Hennerich@...log.com,
        knaack.h@....de, pmeerw@...erw.net, gregkh@...uxfoundation.org
Subject: Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config
 defines

On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote:
> On Sun, Oct 30, 2016 at 06:49:00PM +0000, Jonathan Cameron wrote:
> > On 30/10/16 17:46, Lars-Peter Clausen wrote:
> > > On 10/30/2016 06:41 PM, Jonathan Cameron wrote:
> > >> On 28/10/16 09:26, Eva Rachel Retuya wrote:
> > >>> Introduce defines for shifting and mask under the config register for
> > >>> better readability. Also, introduce helper variables for index
> > >>> calculation.
> > >>>
> > >>> Signed-off-by: Eva Rachel Retuya <eraretuya@...il.com>
> > >> Looks good to me.
> > >>
> > >> Lars could you sanity check this one as well?
> > > 
> > > Acked-by: Lars-Peter Clausen <lars@...afoo.de>
> > There was a bit of fun applying this.  Eva, can you check I didn't mess it
> > up?
> 
> It looks fine to me. Thanks!
> 

Have to retract that statement, I rebased and went through the merge
conflict. Extra whitespace can be seen after the statement in line 644:
	*val = ad7746_cap_filter_rate_table[idx][0];

What to do?
Eva

> > 
> > Applied to the togreg branch of iio.git.  Initially pushed out as testing
> > for the autobuilders to play with it. (and this time I remembered to actually
> > do the push!)
> > 
> > thanks,
> > 
> > Jonathan
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > > the body of a message to majordomo@...r.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > 
> >