[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20161031100523.GY1041@n2100.armlinux.org.uk>
Date: Mon, 31 Oct 2016 10:05:23 +0000
From: Russell King - ARM Linux <linux@...linux.org.uk>
To: Daniel Vetter <daniel@...ll.ch>
Cc: Arnd Bergmann <arnd@...db.de>, Baoyou Xie <baoyou.xie@...aro.org>,
tang.qiang007@....com.cn, xie.baoyou@....com.cn,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
han.fei@....com.cn
Subject: Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible
On Mon, Oct 24, 2016 at 04:27:45PM +0200, Daniel Vetter wrote:
> On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
> > On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
> > > We get 1 warning when building kernel with W=1:
> > > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> > >
> > > In fact, this function is only used in the file in which it is
> > > declared and don't need a declaration, but can be made static.
> > > So this patch marks this function with 'static'.
> > >
> > > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> > >
> >
> > Reviewed-by: Arnd Bergmann <arnd@...db.de>
>
> Applied to drm-misc, thanks.
Argh. This conflicts with my patch series posted before I went away,
so now we're going to end up with merge conflicts... I suppose you're
happy to handle the conflict as you've bypassed waiting for an ack
from the driver maintainer...
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Powered by blists - more mailing lists