linux-kernel - Re: [PATCH 9/9] s390: virtio: make ccw explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2016 11:56:00 +0100
From:   Cornelia Huck <cornelia.huck@...ibm.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     <linux-kernel@...r.kernel.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        <linux-s390@...r.kernel.org>
Subject: Re: [PATCH 9/9] s390: virtio: make ccw explicitly non-modular

On Sun, 30 Oct 2016 16:37:32 -0400
Paul Gortmaker <paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> arch/s390/Kconfig:config S390_GUEST
> arch/s390/Kconfig:      def_bool y
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We replace module.h with moduleparam.h since the file does declare
> some module_param() and leaving that as-is is currently the easiest
> way to remain compatible with existing boot arg use cases.
> 
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: Cornelia Huck <cornelia.huck@...ibm.com>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/s390/virtio/virtio_ccw.c | 25 ++-----------------------
>  1 file changed, 2 insertions(+), 23 deletions(-)

There might actually be a case for making this modular, as the
virtio-pci transport can be built as a module as well. But I don't
think anybody really cares, and your patch is easily reverted should we
want to do this later, so

Acked-by: Cornelia Huck <cornelia.huck@...ibm.com>

[going through the s390 tree with the other patches is probably easier
as taking this through the virtio tree]