linux-kernel - Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201610312130.20261@pali>
Date:   Mon, 31 Oct 2016 21:30:20 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Matt Ranostay <matt@...ostay.consulting>
Cc:     Matt Ranostay <mranostay@...il.com>, Pavel Machek <pavel@....cz>,
        Sebastian Reichel <sre@...nel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
        Linux OMAP List <linux-omap@...r.kernel.org>,
        Tony Lindgren <tony@...mide.com>, khilman@...nel.org,
        aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
        patrikbachan@...il.com, serge@...lyn.com, abcloriens@...il.com
Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

On Monday 31 October 2016 21:22:18 Matt Ranostay wrote:
> On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@...il.com>
> wrote:
> > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@....cz> wrote:
> >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
> >>> Pavel + Sebastian this is the patchset that need I some input on
> >>> :)
> >> 
> >> Better then previous one.
> > 
> >> But my version of bq27xxx_battery.c already contains this:
> > This is for allowing udev rule to set the properties as well.
> > otherwise a kinda crude RUN = " echo value >
> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required.
> 
> Any thoughts on this?

Isn't sysfs /sys/module/bq27xxx_battery/parameters/poll_interval 
attribute what should be used to change module parameters like 
poll_interval?

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)