lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Oct 2016 23:53:42 -0400 (EDT) From: David Miller <davem@...emloft.net> To: mlord@...ox.com Cc: nic_swsd@...ltek.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] r8152: Fix broken RX checksums. From: Mark Lord <mlord@...ox.com> Date: Sun, 30 Oct 2016 22:07:25 -0400 > On 16-10-30 08:57 PM, David Miller wrote: >> From: Mark Lord <mlord@...ox.com> >> Date: Sun, 30 Oct 2016 19:28:27 -0400 >> >>> The r8152 driver has been broken since (approx) 3.16.xx >>> when support was added for hardware RX checksums >>> on newer chip versions. Symptoms include random >>> segfaults and silent data corruption over NFS. >>> >>> The hardware checksum logig does not work on the VER_02 >>> dongles I have here when used with a slow embedded system CPU. >>> Google reveals others reporting similar issues on Raspberry Pi. >>> >>> So, disable hardware RX checksum support for VER_02, and fix >>> an obvious coding error for IPV6 checksums in the same function. >>> >>> Because this bug results in silent data corruption, >>> it is a good candidate for back-porting to -stable >= 3.16.xx. >>> >>> Signed-off-by: Mark Lord <mlord@...ox.com> >> >> Applied and queued up for -stable, thanks. > > Thanks. Now that this is taken care of, I do wonder if perhaps > RX checksums ought to be enabled at all for ANY versions of this chip? You should really start a dialogue with the developer who has been making the most, if not all, of the major changes to this driver over the past few years, Hayes Wang.
Powered by blists - more mailing lists