linux-kernel - Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACna6rx3yxkM8g7_cbuRg_LgH5BNN=cJKHsJ+gKD6+hX57_8-Q@mail.gmail.com>
Date:   Tue, 1 Nov 2016 08:31:58 +0100
From:   Rafał Miłecki <zajec5@...il.com>
To:     John Heenan <john@...s.com>
Cc:     Jes Sorensen <Jes.Sorensen@...hat.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu
 wireless IC

On 1 November 2016 at 08:24, John Heenan <john@...s.com> wrote:
> @@ -5779,6 +5779,12 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw)
>
>         ret = 0;
>
> +       if(priv->fops == &rtl8723bu_fops) {

OK, let me be the first. Documentation/CodingStyle also says to use
space between "if" and "(" ;)


> @@ -6080,9 +6086,11 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>                 goto exit;
>         }
>
> -       ret = rtl8xxxu_init_device(hw);
> -       if (ret)
> -               goto exit;
> +       if(priv->fops != &rtl8723bu_fops) {

Same here.

I reviewed style only.

-- 
Rafał