linux-kernel - Re: [PATCH][resend] drm: bridge: add DesignWare HDMI I2S audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161101093818.GQ1041@n2100.armlinux.org.uk>
Date:   Tue, 1 Nov 2016 09:38:18 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Archit Taneja <architt@...eaurora.org>,
        Mark Brown <broonie@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Fabio Estevam <fabio.estevam@...escale.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Koji Matsuoka <koji.matsuoka.xm@...esas.com>,
        Thierry Reding <treding@...dia.com>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Simon <horms@...ge.net.au>, linux-renesas-soc@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][resend] drm: bridge: add DesignWare HDMI I2S audio
 support

On Tue, Nov 01, 2016 at 12:36:29AM +0000, Kuninori Morimoto wrote:
> 
> Hi Russell again
> 
> > > > +static struct platform_driver snd_dw_hdmi_driver = {
> > > > +	.probe	= snd_dw_hdmi_probe,
> > > 
> > > The driver must have a .remove function, because the platform device it
> > > is binding against can appear and disappear.
> > 
> > Thank you for your feedback
> > OK, I will add it
> 
> This driver uses platform_device_register_full() and calls hdmi-codec
> driver. This driver itself doesn't register sound card, like dw-hdmi-ahb-audio.c
> Then, what does .remove should do in this case ?

Remove the platform device that was created by
platform_device_register_full().

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.