linux-kernel - Re: [PATCH v8 3/3] ARM: davinci: da8xx: register USB PHY clocks in the DT file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dab6f964-21f1-a0c4-643e-6d43568af63a@ti.com>
Date:   Tue, 1 Nov 2016 15:28:39 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     David Lechner <david@...hnology.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kevin Hilman <khilman@...nel.org>
CC:     Axel Haslam <ahaslam@...libre.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 3/3] ARM: davinci: da8xx: register USB PHY clocks in
 the DT file

On Tuesday 01 November 2016 02:17 AM, David Lechner wrote:
> From: Axel Haslam <ahaslam@...libre.com>
> 
> The usb20_phy clock needs to be registered for the driver to be able
> to get and enable a clock. Currently the usb phy clocks are registered
> form board files, which will not be called during a device tree based
> boot.
> 
> To be able to probe correctly usb form a device tree boot, register
> the usb phy clocks form the DT specific init.
> 
> Unfourtunatly, davinci does not have proper clock support on device tree
> yet, so by registering the clock form de DT specific file we are
> forced to hardcode the parent clock, and cannot select refclkin as
> parent for any of the phy clocks of the da850 family.
> 
> As none of the current da850 based boards currently in mainline use
> refclkin as source. I guess we can live with this limitation until clocks
> are correctly represented through CCF/device tree.
> 
> Signed-off-by: Axel Haslam <ahaslam@...libre.com>
> [Added error checking]
> Signed-off-by: David Lechner <david@...hnology.com>

Applied to v4.10/soc with some typo fixes.

s/form/from
s/Unfourtunatly/Unfortunately
s/de/the

Thanks,
Sekhar