linux-kernel - Re: [PATCH] kobject: set state_initialized to 0 in kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161101145638.GA1474@kroah.com>
Date:   Tue, 1 Nov 2016 08:56:38 -0600
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Songjun Wu <songjun.wu@...rochip.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kobject: set state_initialized to 0 in kobject_cleanup

On Tue, Nov 01, 2016 at 06:41:44PM +0800, Songjun Wu wrote:
> If state_initialized is not set to 0 when a kobject is
> released, a device is registered, unregistered, and
> registered again, the error below will occur.
> 
> kobject (dec04bb0): tried to init an initialized object,
> something is seriously wrong.

Yes, your code is wrong, don't try to change the kernel core to work
around it :)

That message is there for a reason, and this patch has been rejected
many times in the past.  kobjects can NOT ever be reused, and should
never be static (but yes, there are lots of in-kernel users with static
kobjects, they just never get reused...)

What code is emitting this message?  I'll be glad to help you fix it up
if you can point me at it.

thanks,

greg k-h