linux-kernel - Re: [PATCH] PCI: create revision file in sysfs

Open Source and information security mailing list archives

Message-ID: <CADnq5_N5_fyJKDpbaew_1t9jNP3+jja+0dAf0WJVOOQ_pOoJXw@mail.gmail.com>
Date:   Tue, 1 Nov 2016 11:47:39 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Emil Velikov <emil.l.velikov@...il.com>
Cc:     Maling list - DRI developers <dri-devel@...ts.freedesktop.org>,
        Jammy Zhou <Jammy.Zhou@....com>,
        Michel Dänzer <michel.daenzer@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI: create revision file in sysfs

On Tue, Nov 1, 2016 at 11:42 AM, Emil Velikov <emil.l.velikov@...il.com> wrote:
> From: Emil Velikov <emil.velikov@...labora.com>
>
> Currently the revision isn't available via sysfs/libudev thus if one
> wants to know the value they need to read through the config file.
>
> This in itself wakes/powers up the device, causing unwanted delay
> since it can be quite costly.
>
> Expose the revision as a separate file, just like we do for the device,
> vendor, their subsystem version and class.
>
> Cc: Jammy Zhou <Jammy.Zhou@....com>
> Cc: Michel Dänzer <michel.daenzer@....com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Emil Velikov <emil.velikov@...labora.com>

Reviewed-by: Alex Deucher <alexander.deucher@....com>

> ---
> Gents, I'm not subscribed to the mailing list so please keep me in the
> CC chain.
>
> Thanks
> Emil
> ---
>  drivers/pci/pci-sysfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index bcd10c7..0666287 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -50,6 +50,7 @@ pci_config_attr(vendor, "0x%04x\n");
>  pci_config_attr(device, "0x%04x\n");
>  pci_config_attr(subsystem_vendor, "0x%04x\n");
>  pci_config_attr(subsystem_device, "0x%04x\n");
> +pci_config_attr(revision, "0x%02x\n");
>  pci_config_attr(class, "0x%06x\n");
>  pci_config_attr(irq, "%u\n");
>
> @@ -568,6 +569,7 @@ static struct attribute *pci_dev_attrs[] = {
>         &dev_attr_device.attr,
>         &dev_attr_subsystem_vendor.attr,
>         &dev_attr_subsystem_device.attr,
> +       &dev_attr_revision.attr,
>         &dev_attr_class.attr,
>         &dev_attr_irq.attr,
>         &dev_attr_local_cpus.attr,
> --
> 2.9.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives