linux-kernel - Re: [PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pomfi3ad.fsf@eliezer.anholt.net>
Date:   Tue, 01 Nov 2016 09:16:26 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, swarren@...dotorg.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

Stefan Wahren <stefan.wahren@...e.com> writes:

>> Eric Anholt <eric@...olt.net> hat am 31. Oktober 2016 um 18:53 geschrieben:
>> 
>> 
>> Stefan Wahren <stefan.wahren@...e.com> writes:
>> 
>> > Hi Eric,
>> >
>> >> Eric Anholt <eric@...olt.net> hat am 27. Oktober 2016 um 18:52 geschrieben:
>> >> 
>> >> 
>> >> From: Linus Walleij <linus.walleij@...aro.org>
>> >> 
>> >> The idea is to give useful names to GPIO lines that an implementer
>> >> will be using from userspace, e.g. for maker type projects.  These are
>> >> user-visible using tools/gpio/lsgpio.c
>> >
>> > sorry for the late feedback, but did you check your patch against the
>> > Firmware
>> > DTS [1]?
>> >
>> > As an example the GPIO38 is connected and named as USB_LIMIT_1A2 since
>> > Raspberry
>> > Pi 1 B Plus.
>> >
>> > [1] -
>> > https://github.com/raspberrypi/documentation/blob/master/configuration/images/dt-blob.dts
>> 
>> I did use the dt-blob sometimes for cross-checking, but these are
>> written against the schematics, not the dt-blob.  If you've got things
>> you'd like changed, could you send a patch?
>
> A patch against your v3 or my own v4 based on your patch?

A followon patch is great, then the changes are obvious and we can
either squash or commit as appropriate.

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)