linux-kernel - Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKzfze8Bom1XYRfiix_qYFckMggUD0eJm3Fz=GhNi6H_PBFyXA@mail.gmail.com>
Date:   Tue, 1 Nov 2016 12:58:57 -0700
From:   Matt Ranostay <mranostay@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Matt Ranostay <matt@...ostay.consulting>, pali.rohar@...il.com,
        Sebastian Reichel <sre@...nel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux OMAP List <linux-omap@...r.kernel.org>,
        Tony Lindgren <tony@...mide.com>, khilman@...nel.org,
        aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
        Patrik Bachan <patrikbachan@...il.com>, serge@...lyn.com,
        Mickuláš Qwertz <abcloriens@...il.com>
Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

On Mon, Oct 31, 2016 at 2:38 PM, Pavel Machek <pavel@....cz> wrote:
> On Mon 2016-10-31 13:22:18, Matt Ranostay wrote:
>> On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@...il.com> wrote:
>> > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@....cz> wrote:
>> >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
>> >>> Pavel + Sebastian this is the patchset that need I some input on :)
>> >>
>> >> Better then previous one.
>> >>
>> >> But my version of bq27xxx_battery.c already contains this:
>> >
>> > This is for allowing udev rule to set the properties as well.
>> > otherwise a kinda crude RUN = " echo value >
>> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required.
>>
>> Any thoughts on this?
>
> I'd say  echo value >
> /sys/module/bq27xxx_battery/parameters/poll_interval .. is quite
> adequate solution...?
>
> Alternatively, convince us that something else is useful for everyone,
> and we can do the right thing (poll more often when battery is nearly
> empty), automatically...

Ok should have had the patchset set it per device, and not use the
global poll_interval. Of need to add some logic to see if uses the
global poll_interval or it's own setting.

There are times where you could have multiple batteries connected to
multiple fuel gauges, and want to up the polling interval on certain
ones that are discharging at different rates.

But of course I'll let you guys let me know if this seems useful at all.


>
>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html