linux-kernel - Re: [PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43669b76-06b0-8dd5-8334-a40936b47e6a@fb.com>
Date:   Wed, 2 Nov 2016 08:59:20 -0600
From:   Jens Axboe <axboe@...com>
To:     Christoph Hellwig <hch@....de>
CC:     <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-block@...r.kernel.org>,
        <jack@...e.cz>
Subject: Re: [PATCH 4/8] writeback: track if we're sleeping on progress in
 balance_dirty_pages()

On 11/02/2016 08:57 AM, Christoph Hellwig wrote:
> On Tue, Nov 01, 2016 at 03:08:47PM -0600, Jens Axboe wrote:
>> Note in the bdi_writeback structure whenever a task ends up sleeping
>> waiting for progress. We can use that information in the lower layers
>> to increase the priority of writes.
>
> Do we need to care about atomicy of multiple threads updating the value
> ?
>
> Otherwise this looks fine.

Don't think we have to care about it too much, it's a soft hint similar
wb->dirty_exceeded.

-- 
Jens Axboe