linux-kernel - [PATCH] EFI loader: remove pointless "if" statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2016 18:03:33 +0300
From:   Eugene Korenevsky <ekorenevsky@...il.com>
To:     linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        Linn Crosetto <linn@....com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>
Subject: [PATCH] EFI loader: remove pointless "if" statement

An obvious cleanup. "if" statement does nothing and should be removed.

---
 arch/x86/boot/compressed/eboot.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index cc69e37..202f2aa 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -1054,11 +1054,7 @@ static efi_status_t exit_boot(struct boot_params *boot_params,
 	/* Historic? */
 	boot_params->alt_mem_k = 32 * 1024;
 
-	status = setup_e820(boot_params, e820ext, e820ext_size);
-	if (status != EFI_SUCCESS)
-		return status;
-
-	return EFI_SUCCESS;
+	return setup_e820(boot_params, e820ext, e820ext_size);
 }
 
 /*
-- 
2.10.2