linux-kernel - Re: [PATCH] coding-style: fix mismatch of jump label name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2016 20:26:43 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Mauro Carvalho Chehab <mchehab@...pensource.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] coding-style: fix mismatch of jump label name

Hi Masahiro-san,

On Thu,  3 Nov 2016 01:57:34 +0900, Masahiro Yamada wrote:
> Commit 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7")
> renamed the label "out_buffer" to "out_free_buffer", but missed to
> change this line.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> Note:
> This patch is based on linux-next.
> The Documentation/CodingStyle was moved to
> Documentation/process/coding-style.rst
> 
>  Documentation/process/coding-style.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 968808be..3e79051 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -475,7 +475,7 @@ The rationale for using gotos is:
>  				...
>  			}
>  			result = 1;
> -			goto out_buffer;
> +			goto out_free_buffer;
>  		}
>  		...
>  	out_free_buffer:

Oops, my bad. Good catch.

Reviewed-by: Jean Delvare <jdelvare@...e.de>

Feel free to add a Fixes: tag, although I doubt this kind of
documentation patch is often backported, so it probably doesn't really
matter.

Thanks,
-- 
Jean Delvare
SUSE L3 Support