linux-kernel - RE: [PATCH] sdhci-esdhc-imx: fix bus-width for 1-bit operation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0401MB232475B15D7D9ED6B78A5E5E90A00@AM4PR0401MB2324.eurprd04.prod.outlook.com>
Date:   Wed, 2 Nov 2016 04:27:36 +0000
From:   Bough Chen <haibo.chen@....com>
To:     "Leonardo G. Veiga" <leogveiga@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "A.S. Dong" <aisheng.dong@....com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "raul.munoz@...adex.com" <raul.munoz@...adex.com>,
        "leonardo.veiga@...adex.com" <leonardo.veiga@...adex.com>
Subject: RE: [PATCH] sdhci-esdhc-imx: fix bus-width for 1-bit operation.

+Aisheng.

Best Regards
Haibo Chen

> -----Original Message-----
> From: linux-mmc-owner@...r.kernel.org [mailto:linux-mmc-
> owner@...r.kernel.org] On Behalf Of Leonardo G. Veiga
> Sent: Tuesday, November 01, 2016 11:58 PM
> To: ulf.hansson@...aro.org
> Cc: linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org;
> stefan@...er.ch; raul.munoz@...adex.com; leonardo.veiga@...adex.com
> Subject: [PATCH] sdhci-esdhc-imx: fix bus-width for 1-bit operation.
> 
> From: Leonardo Graboski Veiga <leonardo.veiga@...adex.com>
> 
> The 1-bit operation mode, enabled by seeting the 'bus-width' property of the
> device tree 'esdhc' node to <1>, not work while using SD card.
> 
> The behavior is only noticed when only the data pin 0 is connected to the
> hardware. A series of kernel errors are printed to the console, all of them
> returning the following error message followed by some explanation:
> mmcblk0: error -84 transferring data
> 
> If four data lines are connected, it ignores the device-tree property and works
> in 4-bit mode of operation without errors. The hardware used for testing does
> not support 8-bit mode.
> 
> Check the 'bus-width' property and if set to <1>, enable the
> SDHCI_QUIRK_FORCE_1_BIT_DATA quirk.
> 
> Signed-off-by: Leonardo Graboski Veiga <leonardo.veiga@...adex.com>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-
> esdhc-imx.c
> index c9fbc4c3..88d7d22 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1003,6 +1003,10 @@ sdhci_esdhc_imx_probe_dt(struct platform_device
> *pdev,
>  		host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
>  	}
> 
> +	if (!of_property_read_u32(np, "bus-width", &boarddata-
> >max_bus_width)
> +		&& boarddata->max_bus_width == 1)
> +		host->quirks |= SDHCI_QUIRK_FORCE_1_BIT_DATA;
> +
>  	/* call to generic mmc_of_parse to support additional capabilities */
>  	ret = mmc_of_parse(host->mmc);
>  	if (ret)
> --
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the
> body of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html