linux-kernel - Re: UBIFS LEB properties tree with odd addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2016 09:10:52 +0100
From:   Richard Weinberger <richard@....at>
To:     Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "dedekind1@...il.com" <dedekind1@...il.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        Punnaiah Choudary Kalluri <punnaia@...inx.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>
Subject: Re: UBIFS LEB properties tree with odd addresses

Naga Sureshkumar Relli,

On 03.11.2016 06:11, Naga Sureshkumar Relli wrote:
> Hi Richard,
> 
>>> Hmm, the calculations in lpt.c use basic properties of the MTD (number of blocks, etc...).
>>> Can you please double check which property causes the failure and also verify whether the MTD driver provides correct properties. i.e. page sizes, block size, number of blocks, ...
> 
>> Hm, these values depend only on basic MTD prperties AFAICT.
>> Mtd->numeraseregions = 0
>> Nor->pagesize = 512
> 
> As per the above query only, I have given the below inputs.
>> Maybe you miss some bit and set incorrect MTD properties.
> I double checked the MTD properties (as mentioned above) which were causing the failure, but didn't find any clue.
> All mtd properties looks good for dual parallel case(there is no odd value).
> 
> Is there any impact by putting below logic in do_calc_lpt_geom() ?
> If(c->pnode_sz % 2)
>     c->pnode_sz += 1;

Yes, we need to understand first what exactly is going on.

> please suggest me to do any further debugging?

Please find the exact MTD property which causes the odd values.
Can you also please share the full kernel log of both cases? (dual and non-dual).
I'm especially interested in the output of UBI.
I have the feeling that we oversee something.

Thanks,
//richard