linux-kernel - Re: [PATCH v4 1/6] Add Advantech iManager MFD core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161103084147.GY13127@dell>
Date:   Thu, 3 Nov 2016 08:41:47 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Richard Vidal-Dorsch <richard.dorsch@...il.com>
Cc:     linus.walleij@...aro.org, gnurou@...il.com, jdelvare@...e.com,
        linux@...ck-us.net, wsa@...-dreams.de, jingoohan1@...il.com,
        tomi.valkeinen@...com, wim@...ana.be, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-watchdog@...r.kernel.org, k.kozlowski@...sung.com,
        jo.sunga@...antech.com, weilun.huang@...antech.com,
        andrew.chou@...antech.com
Subject: Re: [PATCH v4 1/6] Add Advantech iManager MFD core driver

On Wed, 02 Nov 2016, Richard Vidal-Dorsch wrote:

> This patch adds Advantech iManager Embedded Controller MFD core driver.
> This mfd core dirver provides an interface for GPIO, I2C, HWmon,
> Watchdog, and Backlight/Brightness control.
> 
> Signed-off-by: Richard Vidal-Dorsch <richard.dorsch@...il.com>
> ---
>  drivers/mfd/Kconfig             |  18 +
>  drivers/mfd/Makefile            |   1 +
>  drivers/mfd/imanager-core.c     | 941 ++++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/imanager-ec.h | 228 ++++++++++
>  include/linux/mfd/imanager.h    | 221 ++++++++++
>  5 files changed, 1409 insertions(+)
>  create mode 100644 drivers/mfd/imanager-core.c
>  create mode 100644 include/linux/mfd/imanager-ec.h
>  create mode 100644 include/linux/mfd/imanager.h

After a brief review, it is my belief that this looks like a platform
driver, which should live in drivers/platform/.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog