linux-kernel - Re: [PATCH] x86/entry64: move comment about informing of context tracking in right place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161103112434.o6wx4zjdnxodrvzr@pd.tnic>
Date:   Thu, 3 Nov 2016 12:24:35 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Alexander Kuleshov <kuleshovmail@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/entry64: move comment about informing of context
 tracking in right place

On Mon, Oct 24, 2016 at 05:22:34PM +0600, Alexander Kuleshov wrote:
> We are switching to kernel gsbase if an IRQ come from usermode with swpags.

"... if an IRQ comes from ..."

Also, you mean SWAPGS. Instruction names in allcaps please and spelled
correctly please.

> Now there is comment which describes this:
> 
>   IRQ from user mode. Switch to kernel gsbase and inform context tracking that
>   we're in kernel mode.
> 
> But now we execute swapgs, next TRACE_IRQS_OFF and only then the
> CALL_enter_from_user_mode macro expands to the informing of
> context tracking about this event. Let's move part of comment to
> the right place where actual call to context tracing occured.

I don't agree with that change - SWAPGS is part of what the comment
explains so it looks just fine where it is.

For future patches:

Please integrate scripts/checkpatch.pl in your patch creation workflow:

WARNING: 'occured' may be misspelled - perhaps 'occurred'?
#27: 
the right place where actual call to context tracing occured.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.