linux-kernel - Re: [PATCH 4/4] loop: Pass logical blocksize in 'lo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c4b3a45-54f4-4e63-4036-f113554b0be7@suse.de>
Date:   Thu, 3 Nov 2016 14:26:09 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     Christoph Hellwig <hch@....de>
Cc:     Jens Axboe <axboe@...com>, Alexander Graf <agraf@...e.com>,
        Ming@...e.de, "\"Lei" <"tom.leiming\""@gmail.co>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl
 field

On 11/01/2016 03:02 PM, Christoph Hellwig wrote:
> On Mon, Oct 31, 2016 at 08:37:19PM +0100, Hannes Reinecke wrote:
>> The current LOOP_SET_STATUS64 ioctl has two unused fields
>> 'init[2]', which can be used in conjunction with the
>> LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize.
>
> Can we give them sane field names while at it?  Also I see now reason
> not to merge this with the previous two patches.
>
I'd rather not change the name; it's part of the exported ioctl 
interface, and changing would mean to change the ioctl interface.
Which would make quite some user-space programs barf.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)