linux-kernel - Re: [PATCH v2 4/4] KVM: x86: emulate FXSAVE and FXRSTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161103135850.GD7771@potion>
Date:   Thu, 3 Nov 2016 14:58:50 +0100
From:   Radim Krčmář <rkrcmar@...hat.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Bandan Das <bsd@...hat.com>, Nadav Amit <nadav.amit@...il.com>
Subject: Re: [PATCH v2 4/4] KVM: x86: emulate FXSAVE and FXRSTOR

2016-11-03 07:58+0800, kbuild test robot:
> Hi Radim,
> 
> [auto build test ERROR on kvm/linux-next]
> [also build test ERROR on v4.9-rc3 next-20161028]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
> 
> url:    https://github.com/0day-ci/linux/commits/Radim-Kr-m/KVM-x86-emulate-FXSAVE-and-FXRSTOR/20161103-025333
> base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
> config: x86_64-randconfig-s2-11030650 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7

Oh well ...
I dug out a RHEL6.9 machine with "gcc (GCC) 4.4.7 20120313 (Red Hat
4.4.7-18)" and it doesn't compile either, but for a different reason:

> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 

    CC [M]  arch/x86/kvm/emulate.o
  arch/x86/kvm/emulate.c: Assembler messages:
  arch/x86/kvm/emulate.c:3931: Error: no such instruction: `fxsave64 -544(%rbp)'
  arch/x86/kvm/emulate.c:3990: Error: no such instruction: `fxrstor64 -528(%rbp)'
  make[1]: *** [arch/x86/kvm/emulate.o] Error 1
  make: *** [_module_arch/x86/kvm] Error 2

so I wrote the REX.W manually, ".byte 48; fxsave %[fx]", and then the
compilation succeeded:

    CC [M]  arch/x86/kvm/emulate.o
  arch/x86/kvm/emulate.o: warning: objtool: read_sse_reg()+0xb6: function has unreachable instruction

(The output was riddled with warnings about unreachable instructions.)

> All errors (new ones prefixed by >>):
> 
>    arch/x86/kvm/emulate.c: In function 'em_fxsave':
> >> arch/x86/kvm/emulate.c:3931: error: expected string literal before ')' token
>    arch/x86/kvm/emulate.c:3934: error: expected string literal before ')' token
>    arch/x86/kvm/emulate.c: In function 'fx_load_64bit_xmm':
>    arch/x86/kvm/emulate.c:3953: error: expected string literal before ')' token
>    arch/x86/kvm/emulate.c: In function 'em_fxrstor':
>    arch/x86/kvm/emulate.c:3990: error: expected string literal before ')' token
>    arch/x86/kvm/emulate.c:3994: error: expected string literal before ')' token
> 
> vim +3931 arch/x86/kvm/emulate.c
> > 3931			rc = asm_safe("fxsave64 %[fx]", , [fx] "+m"(fx_state) ::);

Seems like it expects something in the clobber list ... maybe it would
work with

  rc = asm_safe("fxsave %[fx]", , [fx] "+m"(fx_state));

I'll install old Debian and send a fix for both issues.
The fix will drop emulation of protected modes, so we won't need the
fxsave64 instruction.