linux-kernel - Re: [PATCH] xattr: Fix setting security xattrs on sockfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d20d694e-a653-e942-6680-7b798a25a260@schaufler-ca.com>
Date:   Thu, 3 Nov 2016 09:25:19 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Andreas Gruenbacher <agruenba@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Stephen Smalley <sds@...ho.nsa.gov>
Subject: Re: [PATCH] xattr: Fix setting security xattrs on sockfs

On 11/3/2016 9:00 AM, Andreas Gruenbacher wrote:
> On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler <casey@...aufler-ca.com> wrote:
>> On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote:
>>> Casey, the first patch broke filesystems that support setxattr for some xattrs
>>> but not security xattrs.  Here's an updated patch; could you please test?
>> This patch does not fix the problem. I am back to EOPTNOTSUP.
> Ah, I forgot to register the new sockfs xattr handler.  Does this help?

Yes. With this addition it looks good.

>
> Thanks,
> Andreas
>
> ---
>  net/socket.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/socket.c b/net/socket.c
> index 816392a..9820725 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -357,6 +357,7 @@ static const struct xattr_handler sockfs_security_xattr_handler = {
>  
>  static const struct xattr_handler *sockfs_xattr_handlers[] = {
>  	&sockfs_xattr_handler,
> +	&sockfs_security_xattr_handler,
>  	NULL
>  };
>