lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Nov 2016 15:33:27 -0500 (CDT) From: Christoph Lameter <cl@...ux.com> To: David Rientjes <rientjes@...gle.com> cc: Thomas Garnier <thgarnie@...gle.com>, Pekka Enberg <penberg@...nel.org>, Joonsoo Kim <iamjoonsoo.kim@....com>, Andrew Morton <akpm@...ux-foundation.org>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, Greg Thelen <gthelen@...gle.com>, Vladimir Davydov <vdavydov.dev@...il.com>, Michal Hocko <mhocko@...nel.org> Subject: Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB On Wed, 2 Nov 2016, David Rientjes wrote: > > Christoph on the first version advised removing invalid flags on the > > caller and checking they are correct in kmem_cache_create. The memcg > > path putting the wrong flags is through create_cache but I still used > > this approach. > > > > I think this is a rather trivial point since it doesn't matter if we clear > invalid flags on the caller or in the callee and obviously > kmem_cache_create() does it in the callee. In order to be correct we need to do the following: kmem_cache_create should check for invalid flags (and that includes internal alloocator flgs) being set and refuse to create the slab cache. memcg needs to call kmem_cache_create without any internal flags. I also want to make sure that there are no other callers that specify extraneou flags while we are at it.
Powered by blists - more mailing lists