linux-kernel - Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161103212646.GB8845@codeblueprint.co.uk>
Date:   Thu, 3 Nov 2016 21:26:46 +0000
From:   Matt Fleming <matt@...eblueprint.co.uk>
To:     Paul Bolle <pebolle@...cali.nl>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        David Howells <dhowells@...hat.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)

On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote:
> Apparently Matt left Intel. Let's forward this to a recently used
> address.
> 
> On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> > hostprogs") correctly noted
> >     [...] that because $(USERINCLUDE) isn't exported by
> >     the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
> > 
> > So let's do the sane thing and remove the reference to that make variable.
> > 
> > Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> > ---
> >  arch/x86/boot/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 12ea8f8384f4..0d810fb15eac 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -65,7 +65,7 @@ clean-files += cpustr.h
> >  
> >  # ---------------------------------------------------------------------------
> >  
> > -KBUILD_CFLAGS	:= $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> > +KBUILD_CFLAGS	:= $(REALMODE_CFLAGS) -D_SETUP
> >  KBUILD_AFLAGS	:= $(KBUILD_CFLAGS) -D__ASSEMBLY__
> >  GCOV_PROFILE := n
> >  UBSAN_SANITIZE := n

Looks OK to me.

Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk>