linux-kernel - Re: [PATCH] staging: lustre: fixed shadowed variable in socklnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKbttoHuY7rw=ozcjkBMKGB2f=Fb_mkvpMurukRDWyGKhvWCDw@mail.gmail.com>
Date:   Fri, 4 Nov 2016 01:22:19 +0300
From:   Andrew Kanner <andrew.kanner@...il.com>
To:     "Dilger, Andreas" <andreas.dilger@...el.com>
Cc:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        "bevans@...y.com" <bevans@...y.com>,
        "bhaktipriya96@...il.com" <bhaktipriya96@...il.com>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: fixed shadowed variable in socklnd_cb.c

2016-11-04 1:12 GMT+03:00 Dilger, Andreas <andreas.dilger@...el.com>:
> On Nov 3, 2016, at 15:54, Andrew Kanner <andrew.kanner@...il.com> wrote:
>>
>> Changed variable 'tx' name in local scope
>> Fixed: sparse warning:
>> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
>> socklnd_cb.c:2435:25: originally declared here
>
> Looking at this more closely (or from a greater distance, hard to say),
> the outer-scope "tx" is used only after this inner-scope "tx", so in
> fact there is no benefit to having the inner-scope declaration at all.
>
> Removing it may save a stack variable (depending on how the compiler
> optimizes), and shouldn't affect functionality.
>
> Cheers, Andreas

I see, I'll correct it and resend as PATCH v2. Thank you.