linux-kernel - Re: [PATCH] clk: sunxi: Fix M factor computation for APB1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161104074940.ak46ghzoa3o3xcie@lukather>
Date:   Fri, 4 Nov 2016 08:49:40 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Stéphan Rafin <stephan@...iotek.com>
Cc:     emilio@...pez.com.ar, mturquette@...libre.com,
        sboyd@...eaurora.org, wens@...e.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...glegroups.com,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: sunxi: Fix M factor computation for APB1

On Fri, Nov 04, 2016 at 12:53:56AM +0100, Stéphan Rafin wrote:
> commit cfa636886033 ("clk: sunxi: factors: Consolidate get_factors
> parameters into a struct") introduced a regression for m factor
> computation in sun4i_get_apb1_factors function.
> 
> The old code reassigned the "parent_rate" parameter to the targeted
> divisor value and was buggy for the returned frequency but not for the
> computed factors. Now, returned frequency is good but m factor is
> incorrectly computed (its max value 31 is always set resulting in a
> significantly slower frequency than the requested one...)
> 
> This patch simply restores the original proper computation for m while
> keeping the good changes for returned rate.
> 
> Signed-off-by: Stéphan Rafin <stephan@...iotek.com>

Applied (added a Fixes tag), thanks

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)