linux-kernel - Re: [patch v1 1/1] leds: verify vendor and change license in mlxcpld driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <e4180b0b-f09f-a9f4-930d-127311704e36@samsung.com>
Date:   Fri, 04 Nov 2016 09:37:52 +0100
From:   Jacek Anaszewski <j.anaszewski@...sung.com>
To:     Vadim Pasternak <vadimp@...lanox.com>, rpurdie@...ys.net
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v1 1/1] leds: verify vendor and change license in mlxcpld
 driver

Hi Vadim,

On 11/03/2016 08:17 PM, Vadim Pasternak wrote:
> Verify that vendor is Mellanox as the first step of initialization.
> If it is not - return ENODEV.
> Change module license from "GPL v2" to "Dual BSD/GPL".
>
> Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> ---
>  drivers/leds/leds-mlxcpld.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-mlxcpld.c b/drivers/leds/leds-mlxcpld.c
> index 197ab9b..281482e 100644
> --- a/drivers/leds/leds-mlxcpld.c
> +++ b/drivers/leds/leds-mlxcpld.c
> @@ -400,6 +400,9 @@ static int __init mlxcpld_led_init(void)
>  	struct platform_device *pdev;
>  	int err;
>
> +	if (!dmi_match(DMI_CHASSIS_VENDOR, "Mellanox Technologies Ltd."))
> +		return -ENODEV;
> +
>  	pdev = platform_device_register_simple(KBUILD_MODNAME, -1, NULL, 0);
>  	if (IS_ERR(pdev)) {
>  		pr_err("Device allocation failed\n");
> @@ -426,5 +429,5 @@ module_exit(mlxcpld_led_exit);
>
>  MODULE_AUTHOR("Vadim Pasternak <vadimp@...lanox.com>");
>  MODULE_DESCRIPTION("Mellanox board LED driver");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_ALIAS("platform:leds_mlxcpld");
>

Thanks for the patch. Applied.

-- 
Best regards,
Jacek Anaszewski