linux-kernel - Re: [PATCH] staging: st-cec: add parentheses around complex macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+M3ks6A=Y9GkKNyS+AFeHor1qN0rNO6uS6e=ayQciHCoG685Q@mail.gmail.com>
Date:   Fri, 4 Nov 2016 10:00:59 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Maninder Singh <maninder.s2@...sung.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel@...inux.com,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        devel@...verdev.osuosl.org,
        Ravikant Bijendra Sharma <ravikant.s2@...sung.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: st-cec: add parentheses around complex macros

Thanks,

Acked-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

2016-11-04 8:58 GMT+01:00 Maninder Singh <maninder.s2@...sung.com>:
> This patch fixes the following checkpatch.pl error:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Maninder Singh <maninder.s2@...sung.com>
> ---
>  drivers/staging/media/st-cec/stih-cec.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
> index 2143448..b22394a 100644
> --- a/drivers/staging/media/st-cec/stih-cec.c
> +++ b/drivers/staging/media/st-cec/stih-cec.c
> @@ -108,11 +108,11 @@
>
>  /* Constants for CEC_BIT_TOUT_THRESH register */
>  #define CEC_SBIT_TOUT_47MS BIT(1)
> -#define CEC_SBIT_TOUT_48MS BIT(0) | BIT(1)
> +#define CEC_SBIT_TOUT_48MS (BIT(0) | BIT(1))
>  #define CEC_SBIT_TOUT_50MS BIT(2)
>  #define CEC_DBIT_TOUT_27MS BIT(0)
>  #define CEC_DBIT_TOUT_28MS BIT(1)
> -#define CEC_DBIT_TOUT_29MS BIT(0) | BIT(1)
> +#define CEC_DBIT_TOUT_29MS (BIT(0) | BIT(1))
>
>  /* Constants for CEC_BIT_PULSE_THRESH register */
>  #define CEC_BIT_LPULSE_03MS BIT(1)
> --
> 1.7.9.5
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog