linux-kernel - Re: [PATCH v6 1/3] LSM: Add /sys/kernel/security/lsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201611042311.IHI81705.FSOQVMtFJLOFHO@I-love.SAKURA.ne.jp>
Date:   Fri, 4 Nov 2016 23:11:54 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:     casey@...aufler-ca.com, linux-security-module@...r.kernel.org,
        jmorris@...ei.org
Cc:     john.johansen@...onical.com, paul@...l-moore.com,
        keescook@...omium.org, sds@...ho.nsa.gov,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] LSM: Add /sys/kernel/security/lsm

Casey Schaufler wrote:
> On 11/1/2016 5:53 AM, Tetsuo Handa wrote:
> > I didn't check past discussion, but how do you handle security_delete_hooks()
> > case (I mean, "selinux" will remain there when reading /sys/kernel/security/lsm
> > even after it is disabled at runtime)?
> 
> Paul Moore says that SELinux is going to remove the ability
> to delete itself in the near future. Since that's the only
> module that allows deletion I don't see that it's an issue.

OK.

> 
> > I think holding module name as one of
> > "union security_list_options" members will avoid memory allocation handling
> > and simplify things.
> 
> I don't see how that would simplify things, and the memory
> allocation handling here is pretty basic.

I expected we can use simple_read_from_buffer() from iteration loop,
but I found it does not work like I want. So, it did not simplify things.