[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161104150637.ejyxq5rfwcwggo3q@pd.tnic>
Date: Fri, 4 Nov 2016 16:06:37 +0100
From: Borislav Petkov <bp@...en8.de>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: He Chen <he.chen@...ux.intel.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org, x86@...nel.org,
Radim Krčmář <rkrcmar@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H . Peter Anvin" <hpa@...or.com>,
Luwei Kang <luwei.kang@...el.com>,
Piotr Luc <Piotr.Luc@...el.com>
Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS
features to kvm guest
On Fri, Nov 04, 2016 at 03:53:02PM +0100, Paolo Bonzini wrote:
> > The modification to scattered et al without the kvm use should be a
> > separate patch.
>
> With no usage? Sounds like a good use of Acked-by. :)
I don't understand what do you mean here?
> >> +u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf,
> >> + enum cpuid_regs_idx reg)
> >
> > Align arguments on the opening brace.
>
> They are aligned.
Right you are. I need to look into why those spaces get eaten in vim.
Looks like something is replacing 4 spaces with a single one...
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Powered by blists - more mailing lists