linux-kernel - Re: [PATCH v3] console: use first console if stdout-path device doesn't appear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161104153852.GA422@swordfish>
Date:   Sat, 5 Nov 2016 00:44:51 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Paul Burton <paul.burton@...tec.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Michael Ellerman <mpe@...erman.id.au>,
        Andreas Schwab <schwab@...ux-m68k.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Borislav Petkov <bp@...e.de>, Petr Mladek <pmladek@...e.com>,
        Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v3] console: use first console if stdout-path device
 doesn't appear

Hi Paul,

On (11/03/16 21:17), Paul Burton wrote:
> > [..]
> > > +			 * The device tree stdout-path chosen node property was
> > > +			 * specified so we don't want to enable the first
> > > +			 * registered console just now in order to give the
> > > +			 * device indicated by stdout-path a chance to be
> > > +			 * registered first. Do however keep track of the
> > > +			 * first console we see so that we can fall back to
> > > +			 * using it if we don't see the desired device, either
> > > +			 * because stdout-path isn't valid, or because we have
> > > +			 * no driver for the device or our driver doesn't call
> > > +			 * of_console_check(). See printk_late_init() for this
> > > +			 * fallback.
> > 
> > if the path is not valid then correct the path. no?
> 
> ...but what if the path is valid and we simply don't have a driver for the 
> device it references? As I said in that comment we may not have a driver at 
> all.

well, I suppose, in this case normally one would go and enable the
missing .config option. no?

	-ss