linux-kernel - Re: [PATCH V3 0/6] ARM64: Uprobe support added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161104184652.rxllldll4qfe7qdn@localhost>
Date:   Fri, 4 Nov 2016 12:46:52 -0600
From:   Catalin Marinas <catalin.marinas@....com>
To:     Pratyush Anand <panand@...hat.com>
Cc:     steve.capper@...aro.org, srikar@...ux.vnet.ibm.com,
        vijaya.kumar@...iumnetworks.com, will.deacon@....com,
        linux-kernel@...r.kernel.org, oleg@...hat.com, wcohen@...hat.com,
        linux-arm-kernel@...ts.infradead.org, dave.long@...hat.com
Subject: Re: [PATCH V3 0/6] ARM64: Uprobe support added

On Fri, Nov 04, 2016 at 11:49:51AM -0600, Catalin Marinas wrote:
> On Wed, Nov 02, 2016 at 02:40:40PM +0530, Pratyush Anand wrote:
> > Pratyush Anand (6):
> >   arm64: kprobe: protect/rename few definitions to be reused by uprobe
> >   arm64: kgdb_step_brk_fn: ignore other's exception
> >   arm64: Handle TRAP_TRACE for user mode as well
> >   arm64: Handle TRAP_BRKPT for user mode as well
> >   arm64: introduce mm context flag to keep 32 bit task information
> >   arm64: Add uprobe support
> 
> I queued the patches for 4.10. I will push them into -next sometime next
> week once I do some testing (I'm currently at the LPC).

I spoke too soon. With these patches on top of 4.9-rc3, defconfig
together with FTRACE and UPROBE_EVENT enabled I get:

In file included from /work/Linux/linux-2.6-aarch64/arch/arm64/kernel/probes/decode-insn.c:20:0:
/work/Linux/linux-2.6-aarch64/arch/arm64/include/asm/kprobes.h:52:5: error: conflicting types for 'kprobe_fault_handler'
 int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr);
     ^~~~~~~~~~~~~~~~~~~~
In file included from /work/Linux/linux-2.6-aarch64/arch/arm64/kernel/probes/decode-insn.c:17:0:
/work/Linux/linux-2.6-aarch64/include/linux/kprobes.h:398:90: note: previous definition of 'kprobe_fault_handler' was here
 static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
                                                                                          ^                   
/work/Linux/linux-2.6-aarch64/scripts/Makefile.build:290: recipe for target 'arch/arm64/kernel/probes/decode-insn.o' failed

-- 
Catalin