linux-kernel - Re: [PATCH] i2c: make busses/i2c-pxa-pci.c explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161104194748.GB1478@katana>
Date:   Fri, 4 Nov 2016 20:47:49 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: make busses/i2c-pxa-pci.c explicitly non-modular

On Mon, Oct 31, 2016 at 01:59:47PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/i2c/busses/Kconfig:config I2C_PXA_PCI
> drivers/i2c/busses/Kconfig:     def_bool I2C_PXA && X86_32 && PCI && OF
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since module_pci_driver() uses the same init level priority as
> builtin_pci_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Cc: linux-i2c@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Looks OK to me, still I'd like an ack from Sebastian for this patch.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)