linux-kernel - Re: [PATCH] pinctrl: sunxi: make bool drivers explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbDk33ffD=S39KjgPh6bcY6QrjCs6gpyC6TherO4kv-4Q@mail.gmail.com>
Date:   Fri, 4 Nov 2016 23:27:06 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Patrice Chotard <patrice.chotard@...com>,
        Hongzhou Yang <hongzhou.yang@...iatek.com>,
        Fabian Frederick <fabf@...net.be>,
        Maxime Coquelin <maxime.coquelin@...com>,
        Vishnu Patekar <vishnupatekar0510@...il.com>,
        Mylene Josserand <mylene.josserand@...e-electrons.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] pinctrl: sunxi: make bool drivers explicitly non-modular

On Sun, Oct 30, 2016 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> None of the Kconfigs for any of these drivers are tristate,
> meaning that they currently are not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the drivers there is no doubt they are builtin-only.  All
> drivers get essentially the same change, so they are handled in batch.
>
> Changes are (1) use builtin_platform_driver, (2) use init.h header
> (3) delete module_exit related code, (4) delete MODULE_DEVICE_TABLE,
> and (5) delete MODULE_LICENCE/MODULE_AUTHOR and associated tags.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We do delete the MODULE_LICENSE etc. tags since all that information
> is already contained at the top of each file in the comments.
>
> Cc: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Patrice Chotard <patrice.chotard@...com>
> Cc: Hongzhou Yang <hongzhou.yang@...iatek.com>
> Cc: Fabian Frederick <fabf@...net.be>
> Cc: Maxime Coquelin <maxime.coquelin@...com>
> Cc: Vishnu Patekar <vishnupatekar0510@...il.com>
> Cc: Mylene Josserand <mylene.josserand@...e-electrons.com>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij