linux-kernel - Re: [PATCH V2 2/2] ARM: dts: add new compatible stream for i.MX6QP mmdc

Open Source and information security mailing list archives

Message-ID: <20161105074350.GD5597@dragon>
Date:   Sat, 5 Nov 2016 15:43:52 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Frank Li <Frank.Li@....com>
Cc:     mark.rutland@....com, peterz@...radead.org,
        linux-kernel@...r.kernel.org, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, mingo@...hat.com,
        lznuaa@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V2 2/2] ARM: dts: add new compatible stream for i.MX6QP
 mmdc

On Wed, Nov 02, 2016 at 01:00:04PM -0500, Frank Li wrote:
> mmdc of i.MX6QP are little difference with i.MX6Q.
> added new compatible stream fsl,imx6qp-mmdc

s/stream/string

> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> No change for this patch.
> suspend resume code need fsl,imx6q-mmdc

You should probably add such info into commit log, e.g. although
MMDC has a slightly different programming model between imx6q and imx6qp
in terms of perf support, it's exactly same for suspend support, so we
have fsl,imx6q-mmdc here to save patching suspend driver with the new
compatible.

> 
>  arch/arm/boot/dts/imx6qp.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
> index 886dbf2..e0fdd0f 100644
> --- a/arch/arm/boot/dts/imx6qp.dtsi
> +++ b/arch/arm/boot/dts/imx6qp.dtsi
> @@ -85,5 +85,12 @@
>  		pcie: pcie@...1000000 {
>  			compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
>  		};
> +
> +		aips-bus@...00000 {
> +			mmdc0: mmdc@...b0000 { /* MMDC0 */
> +				compatible = "fsl,imx6qp-mmdc", "fsl,imx6q-mmdc";
> +				reg = <0x021b0000 0x4000>;
> +			};
> +		};

It seems that pcie already went wrong, but please still try to add
devices in order of unit-address.

Shawn

>  	};
>  };
> -- 
> 2.5.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives