linux-kernel - Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BCsVwwZ_K9-3VFvK1QuX7gAAabii3czZf35ohR_vuTVA@mail.gmail.com>
Date:   Sun, 6 Nov 2016 20:05:01 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Timur Tabi <timur@...i.org>, Nicolin Chen <nicoleotsuka@...il.com>,
        Xiubo Li <Xiubo.Lee@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Geliang Tang <geliangtang@....com>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors

Hi Randy,

On Sun, Nov 6, 2016 at 7:40 PM, Randy Dunlap <rdunlap@...radead.org> wrote:

> The driver uses bitreverse functions but does not select BITREVERSE
> in its kconfig description, so the bitrev functions are not built
> into the kernel.  In the kbuild robot supplied config file,
> FSL_SPDIF=y and BITREVERSE=m, which causes the build error.
> By having this driver select BITREVERSE, CONFIG_BITREVERSE=y so there
> is no build error.

This makes sense, thanks:

Reviewed-by: Fabio Estevam <fabio.estevam@....com>