linux-kernel - Re: [PATCH] This is a patch to the capi.c file that fixes one instance of the following error: ERROR: do not use assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201611061747.eFAXJFiE%fengguang.wu@intel.com>
Date:   Sun, 6 Nov 2016 17:28:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Naeil ZOUEIDI <naeilzoueidi@...ntu.com>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org,
        bankarsandhya512@...il.com, isdn@...ux-pingi.de,
        sudipm.mukherjee@...il.com, arnd@...db.de, ansonjacob.aj@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Naeil ZOUEIDI <naeilzoueidi@...ntu.com>
Subject: Re: [PATCH] This is a patch to the capi.c file that fixes one
 instance of the following error: ERROR: do not use assignment in if
 condition

Hi Naeil,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.9-rc4 next-20161028]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Naeil-ZOUEIDI/This-is-a-patch-to-the-capi-c-file-that-fixes-one-instance-of-the-following-error-ERROR-do-not-use-assignment-in-if-condition/20161106-165820
config: i386-randconfig-x077-201645 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/staging/i4l/act2000/capi.c: In function 'actcapi_data_b3_ind':
>> drivers/staging/i4l/act2000/capi.c:571:32: error: expected ')' before ';' token
     skb = alloc_skb(11, GFP_ATOMIC;
                                   ^
>> drivers/staging/i4l/act2000/capi.c:586:1: error: expected ';' before '}' token
    }
    ^
>> drivers/staging/i4l/act2000/capi.c:586:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +571 drivers/staging/i4l/act2000/capi.c

   565			return 0;
   566		if (card->bch[chan].plci != plci)
   567			return 0;
   568		blocknr = msg->msg.data_b3_ind.blocknr;
   569		skb_pull(skb, 19);
   570		card->interface.rcvcallb_skb(card->myid, chan, skb);
 > 571		skb = alloc_skb(11, GFP_ATOMIC;
   572		if (!skb) {
   573			printk(KERN_WARNING "actcapi: alloc_skb failed\n");
   574			return 1;
   575		}
   576		msg = (actcapi_msg *)skb_put(skb, 11);
   577		msg->hdr.len = 11;
   578		msg->hdr.applicationID = 1;
   579		msg->hdr.cmd.cmd = 0x86;
   580		msg->hdr.cmd.subcmd = 0x03;
   581		msg->hdr.msgnum = actcapi_nextsmsg(card);
   582		msg->msg.data_b3_resp.ncci = ncci;
   583		msg->msg.data_b3_resp.blocknr = blocknr;
   584		ACTCAPI_QUEUE_TX;
   585		return 1;
 > 586	}
   587	
   588	/*
   589	 * Walk over ackq, unlink DATA_B3_REQ from it, if

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29790 bytes)