linux-kernel - [BUG] ipmi: NULL device printing in check_set_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2016 10:57:44 +0100
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     minyard@....org
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: [BUG] ipmi: NULL device printing in check_set_rcv_irq()

Hello

On one of my servers I got this line in dmesg
(NULL device *): The BMC does not support setting the recv irq bit, compensating, but the BMC needs to be fixed.

This printing is done via a dev_warn(smi_info->dev,) in drivers/char/ipmi/ipmi_si_intf.c:check_clr_rcv_irq() but smi_info->dev is set only latter in try_smi_init().

I do not know which way is better to fix it, either move the code block which register the device before check_for_broken_irqs(), or perhaps replace dev_warn by pr_warn.

Regards
Corentin Labbe