linux-kernel - Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error returned by lustre_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161107104030.GB19871@kroah.com>
Date:   Mon, 7 Nov 2016 11:40:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     James Simmons <jsimmons@...radead.org>
Cc:     Oleg Drokin <oleg.drokin@...el.com>, devel@...verdev.osuosl.org,
        andreas.dilger@...el.com, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        emoly.liu@...el.com, lustre-devel@...ts.lustre.org
Subject: Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error
 returned by lustre_cfg_new

On Mon, Nov 07, 2016 at 04:10:16AM +0000, James Simmons wrote:
> 
> > On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote:
> > 
> > > 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
> > > Handle these errors and propagate the error code to the callers.
> > > 
> > > Error handling has been rearranged in 'lustre_process_log()' with the
> > > addition of a label in order to free some resources.
> > 
> > I wonder if we should just make it return NULL on allocation failure,
> > and then at least the other error handling that is there (i.e. in your other patch)
> > would become correct.
> > This would make handling in mgc_apply_recover_logs incorrect, but it's already
> > geared towards this sort of handling anyway, as it discards the passed error
> > and sets ENOMEM unconditionally (just need to revert 3092c34a in a way).
> 
> The header lustre_cfg.h is meant to be a UAPI header file. It is used for 
> our userland tools but with the current shape of lustre_cfg.h upstream our 
> tools will not build with it. So having kzalloc and kfree in this header
> is incorrect. To do this right I need to update our user land tools as 
> well so we should hold off on these patches.

Ok, but the code as-is today is incorrect, so that should get fixed
somehow, soon...

thanks,

greg k-h