linux-kernel - Re: [PATCH 04/14] staging/lustre/llite: clear inode timestamps after losing UPDATE lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1611070137440.21293@casper.infradead.org>
Date:   Mon, 7 Nov 2016 01:38:03 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Oleg Drokin <green@...uxhacker.ru>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        Niu Yawei <yawei.niu@...el.com>,
        Jinshan Xiong <jinshan.xiong@...el.com>
Subject: Re: [PATCH 04/14] staging/lustre/llite: clear inode timestamps after
 losing UPDATE lock


> From: Niu Yawei <yawei.niu@...el.com>
> 
> Otherwise, those leftovers would interfere with new timestamps
> especially when the timestamps are set back in time on the other
> clients.

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Signed-off-by: Jinshan Xiong <jinshan.xiong@...el.com>
> Signed-off-by: Niu Yawei <yawei.niu@...el.com>
> Reviewed-on: http://review.whamcloud.com/22623
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8446
> Reviewed-by: Bobi Jam <bobijam@...mail.com>
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> ---
>  drivers/staging/lustre/lustre/llite/namei.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
> index 74d9b73..c268f32 100644
> --- a/drivers/staging/lustre/lustre/llite/namei.c
> +++ b/drivers/staging/lustre/lustre/llite/namei.c
> @@ -251,6 +251,16 @@ int ll_md_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
>  				       PFID(ll_inode2fid(inode)), rc);
>  		}
>  
> +		if (bits & MDS_INODELOCK_UPDATE) {
> +			struct ll_inode_info *lli = ll_i2info(inode);
> +
> +			spin_lock(&lli->lli_lock);
> +			LTIME_S(inode->i_mtime) = 0;
> +			LTIME_S(inode->i_atime) = 0;
> +			LTIME_S(inode->i_ctime) = 0;
> +			spin_unlock(&lli->lli_lock);
> +		}
> +
>  		if ((bits & MDS_INODELOCK_UPDATE) && S_ISDIR(inode->i_mode)) {
>  			struct ll_inode_info *lli = ll_i2info(inode);
>  
> -- 
> 2.7.4
> 
>