linux-kernel - Re: [PATCH 07/14] staging/lustre/ldlm: Reinstate ldlm_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1611070153200.21293@casper.infradead.org>
Date:   Mon, 7 Nov 2016 01:53:41 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Oleg Drokin <green@...uxhacker.ru>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 07/14] staging/lustre/ldlm: Reinstate
 ldlm_enqueue_pack()


> The function becomes used again with the next patch, so bring it back
> from dead, only this time make it static.

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Reverts: bf2a033360f7 ("staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()")
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> ---
>  drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> index 6e704c7..1b9ae77 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> @@ -657,6 +657,27 @@ int ldlm_prep_enqueue_req(struct obd_export *exp, struct ptlrpc_request *req,
>  }
>  EXPORT_SYMBOL(ldlm_prep_enqueue_req);
>  
> +static struct ptlrpc_request *ldlm_enqueue_pack(struct obd_export *exp,
> +						int lvb_len)
> +{
> +	struct ptlrpc_request *req;
> +	int rc;
> +
> +	req = ptlrpc_request_alloc(class_exp2cliimp(exp), &RQF_LDLM_ENQUEUE);
> +	if (!req)
> +		return ERR_PTR(-ENOMEM);
> +
> +	rc = ldlm_prep_enqueue_req(exp, req, NULL, 0);
> +	if (rc) {
> +		ptlrpc_request_free(req);
> +		return ERR_PTR(rc);
> +	}
> +
> +	req_capsule_set_size(&req->rq_pill, &RMF_DLM_LVB, RCL_SERVER, lvb_len);
> +	ptlrpc_request_set_replen(req);
> +	return req;
> +}
> +
>  /**
>   * Client-side lock enqueue.
>   *
> -- 
> 2.7.4
> 
>